Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: AT mode support the URL of a PGSQL cluster #6261

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5359

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels Jan 15, 2024
@funky-eyes funky-eyes added this to the 2.1.0 milestone Jan 15, 2024
@funky-eyes funky-eyes changed the title bugfix: pgsql cluster mode is supported bugfix: AT mode support the URL of a PGSQL cluster Jan 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2101a95) 50.95% compared to head (43810de) 51.03%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6261      +/-   ##
============================================
+ Coverage     50.95%   51.03%   +0.08%     
- Complexity     5087     5095       +8     
============================================
  Files           917      917              
  Lines         32022    32024       +2     
  Branches       3862     3863       +1     
============================================
+ Hits          16318    16345      +27     
+ Misses        14132    14105      -27     
- Partials       1572     1574       +2     
Files Coverage Δ
...n/java/io/seata/rm/datasource/DataSourceProxy.java 71.18% <100.00%> (+10.61%) ⬆️

... and 5 files with indirect coverage changes

@funky-eyes funky-eyes closed this Jan 15, 2024
@funky-eyes funky-eyes reopened this Jan 15, 2024
slievrly
slievrly previously approved these changes Jan 16, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit a59a39a into apache:2.x Jan 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seata的at模式,数据源为postgresql的问题
3 participants