Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize some files #6238

Merged
merged 8 commits into from
Jan 8, 2024
Merged

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jan 5, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize some files

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

funky-eyes
funky-eyes previously approved these changes Jan 5, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26feac2) 50.00% compared to head (504c78c) 49.83%.
Report is 2 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6238      +/-   ##
============================================
- Coverage     50.00%   49.83%   -0.18%     
+ Complexity     4932     4926       -6     
============================================
  Files           915      917       +2     
  Lines         31927    31995      +68     
  Branches       3855     3862       +7     
============================================
- Hits          15966    15944      -22     
- Misses        14400    14490      +90     
  Partials       1561     1561              
Files Coverage Δ
.../io/seata/core/rpc/netty/v1/ProtocolV1Encoder.java 5.12% <ø> (ø)
.../java/io/seata/sqlparser/druid/BaseRecognizer.java 80.95% <ø> (ø)
...a/sqlparser/druid/oracle/BaseOracleRecognizer.java 35.29% <ø> (ø)
...ser/druid/postgresql/BasePostgresqlRecognizer.java 23.21% <ø> (ø)
...arser/druid/sqlserver/BaseSqlServerRecognizer.java 54.54% <ø> (ø)

... and 21 files with indirect coverage changes

# Conflicts:
#	console/src/main/resources/static/console-fe/src/components/Header/Header.tsx
# Conflicts:
#	console/src/main/resources/static/console-fe/src/components/Header/Header.tsx
funky-eyes
funky-eyes previously approved these changes Jan 8, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liuqiufeng liuqiufeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 2433b8f into apache:2.x Jan 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants