Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the problem that The incorrect configuration needs to be fixed #6204

Merged
merged 4 commits into from
Dec 25, 2023

Conversation

dreamskyvision
Copy link
Contributor

@dreamskyvision dreamskyvision commented Dec 25, 2023

The incorrect configuration needs to be fixed. fixed. #6203

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6203

Ⅲ. Why don't you add test cases (unit test/integration test)?

it’s just a single configeration file modify

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title bugfix: fix the problem that The incorrect configuration needs to be fixed. #6203 bugfix: fix the problem that The incorrect configuration needs to be fixed Dec 25, 2023
@funky-eyes funky-eyes added first-time contributor first-time contributor module/server server module module/script script module labels Dec 25, 2023
@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a57f2d) 49.03% compared to head (9777d39) 48.94%.

❗ Current head 9777d39 differs from pull request most recent head a541f43. Consider uploading reports for the commit a541f43 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6204      +/-   ##
============================================
- Coverage     49.03%   48.94%   -0.10%     
+ Complexity     4786     4776      -10     
============================================
  Files           915      915              
  Lines         31896    31896              
  Branches       3855     3855              
============================================
- Hits          15641    15611      -30     
- Misses        14699    14722      +23     
- Partials       1556     1563       +7     

see 7 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit f3b27de into apache:2.x Dec 25, 2023
5 checks passed
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/script script module module/server server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The incorrect configuration needs to be fixed.
5 participants