Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: console log optimize for "kubectl logs -f" #6154

Merged
merged 5 commits into from
Dec 25, 2023

Conversation

PeppaO
Copy link
Contributor

@PeppaO PeppaO commented Dec 14, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

仅输出启动日志到控制台便于启动报错排查
fixes #6152

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #6154 (4592576) into 2.x (5563492) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6154      +/-   ##
============================================
+ Coverage     48.94%   48.95%   +0.01%     
- Complexity     4775     4779       +4     
============================================
  Files           913      913              
  Lines         31710    31711       +1     
  Branches       3827     3827              
============================================
+ Hits          15521    15525       +4     
+ Misses        14653    14643      -10     
- Partials       1536     1543       +7     
Files Coverage Δ
...c/main/java/io/seata/server/ServerApplication.java 25.00% <0.00%> (-8.34%) ⬇️

... and 7 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实现的有些粗糙,我希望有更优的解决方案
The implementation is a bit rough, I hope there is a better solution

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e590de5) 48.95% compared to head (f0f4edb) 49.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6154      +/-   ##
============================================
+ Coverage     48.95%   49.00%   +0.05%     
- Complexity     4778     4783       +5     
============================================
  Files           915      915              
  Lines         31892    31896       +4     
  Branches       3853     3855       +2     
============================================
+ Hits          15613    15631      +18     
+ Misses        14720    14710      -10     
+ Partials       1559     1555       -4     
Files Coverage Δ
...ver/spring/listener/ServerApplicationListener.java 44.44% <100.00%> (+5.42%) ⬆️

... and 4 files with indirect coverage changes

funky-eyes
funky-eyes previously approved these changes Dec 22, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 22, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 1a57f2d into apache:2.x Dec 25, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants