-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: console log optimize for "kubectl logs -f" #6154
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6154 +/- ##
============================================
+ Coverage 48.94% 48.95% +0.01%
- Complexity 4775 4779 +4
============================================
Files 913 913
Lines 31710 31711 +1
Branches 3827 3827
============================================
+ Hits 15521 15525 +4
+ Misses 14653 14643 -10
- Partials 1536 1543 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
实现的有些粗糙,我希望有更优的解决方案
The implementation is a bit rough, I hope there is a better solution
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6154 +/- ##
============================================
+ Coverage 48.95% 49.00% +0.05%
- Complexity 4778 4783 +5
============================================
Files 915 915
Lines 31892 31896 +4
Branches 3853 3855 +2
============================================
+ Hits 15613 15631 +18
+ Misses 14720 14710 -10
+ Partials 1559 1555 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
仅输出启动日志到控制台便于启动报错排查
fixes #6152
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews