Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize the retry logic in the acquireMetadata method #6098

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

ggbocoder
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fixes #6097

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.1.0 milestone Nov 30, 2023
@funky-eyes funky-eyes changed the title optimize:optimize the retry logic in the acquireMetadata method optimize: optimize the retry logic in the acquireMetadata method Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #6098 (98f5538) into 2.x (fb6b20e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6098   +/-   ##
=========================================
  Coverage     49.23%   49.23%           
  Complexity     4790     4790           
=========================================
  Files           913      913           
  Lines         31679    31677    -2     
  Branches       3823     3824    +1     
=========================================
  Hits          15596    15596           
+ Misses        14538    14536    -2     
  Partials       1545     1545           
Files Coverage Δ
...scovery/registry/raft/RaftRegistryServiceImpl.java 17.77% <0.00%> (+0.15%) ⬆️

... and 3 files with indirect coverage changes

…y/registry/raft/RaftRegistryServiceImpl.java

Co-authored-by: funkye <[email protected]>
@funky-eyes funky-eyes added the module/discovery discovery module label Dec 1, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit b2ac653 into apache:2.x Dec 1, 2023
8 checks passed
l81893521 pushed a commit to l81893521/seata that referenced this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When all Raft nodes are offline, it will retry indefinitely after the maximum metadata delay is reached.
2 participants