feature: support passing contextPath parameter to Nacos client
#5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5111 +/- ##
==========================================
Coverage 49.35% 49.35%
- Complexity 4145 4147 +2
==========================================
Files 737 737
Lines 26190 26198 +8
Branches 3232 3232
==========================================
+ Hits 12925 12931 +6
- Misses 11881 11885 +4
+ Partials 1384 1382 -2
|
config/seata-config-nacos/src/main/java/io/seata/config/nacos/NacosConfiguration.java
Outdated
Show resolved
Hide resolved
wangliang181230
changed the title
contextPath parameter to Nacos client
funky-eyes
added
type: feature
slievrly
reviewed
Dec 2, 2022
zw201913
pushed a commit
to zw201913/seata
that referenced
this pull request
Dec 12, 2022
…o 1114_for_5073 * '1114_for_5073' of https://github.com/zw201913/seata: bugfix: hikari datasource auto proxy fail (apache#5134) bugfix: rollback active xa connection fail (apache#5131) optimize: support oracle on delete tccfence logs (apache#5124) feature: support passing `contextPath` parameter to Nacos client (apache#5111) bugfix:NPE caused when there is no @GlobalTransactional annotation on the RM side (apache#5109) bugfix: Druid disable oracle implicit cache (apache#5098) bugfix: fix access key loss after server restart (apache#5097) optimize: remove druid dependency in ConnectionProxy (apache#5104) bugfix:fix ClassNotFoundException during the ZK unit test (apache#5101) bugfix: fix when seata and jpa are used together, their AutoConfiguration order is incorrect (apache#5092) optimize: lock priority attempts to insert (apache#4681) bugfix: update join condition placeholder param error (apache#5052)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Support passing contextPath parameter to Nacos client
Ⅱ. Does this pull request fix one issue?
fixes #5110
fixes #5012
Ⅲ. Why don't you add test cases (unit test/integration test)?
I provided some screenshots of the test
Ⅳ. Describe how to verify it
Use nacos as discovery center and config center,and set the value of contextPath.
Ⅴ. Special notes for reviews