Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove druid dependency in ConnectionProxy #5104

Merged
merged 6 commits into from
Nov 24, 2022

Conversation

l81893521
Copy link
Contributor

@l81893521 l81893521 commented Nov 23, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

remove the druid dependency in ConnectionProxy

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@l81893521 l81893521 added this to the 1.6.0 milestone Nov 23, 2022
@l81893521 l81893521 added the module/rm-datasource rm-datasource module label Nov 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@6673078). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5104   +/-   ##
==========================================
  Coverage           ?   49.34%           
  Complexity         ?     4143           
==========================================
  Files              ?      737           
  Lines              ?    26187           
  Branches           ?     3233           
==========================================
  Hits               ?    12921           
  Misses             ?    11881           
  Partials           ?     1385           
Impacted Files Coverage Δ
...n/java/io/seata/rm/datasource/ConnectionProxy.java 25.67% <100.00%> (ø)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changes/en-us/develop.md Outdated Show resolved Hide resolved
@l81893521 l81893521 changed the title optimize: remote druid dependency in ConnectionProxy optimize: remove druid dependency in ConnectionProxy Nov 23, 2022
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 04e4fb5 into apache:develop Nov 24, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zw201913 pushed a commit to zw201913/seata that referenced this pull request Dec 12, 2022
…o 1114_for_5073

* '1114_for_5073' of https://github.com/zw201913/seata:
  bugfix: hikari datasource auto proxy fail (apache#5134)
  bugfix: rollback active xa connection fail (apache#5131)
  optimize: support oracle on delete tccfence logs  (apache#5124)
  feature: support passing `contextPath` parameter to Nacos client (apache#5111)
  bugfix:NPE caused when there is no @GlobalTransactional annotation on the RM side  (apache#5109)
  bugfix: Druid disable oracle implicit cache (apache#5098)
  bugfix: fix access key loss after server restart (apache#5097)
  optimize: remove druid dependency in ConnectionProxy (apache#5104)
  bugfix:fix ClassNotFoundException during the ZK unit test (apache#5101)
  bugfix: fix when seata and jpa are used together, their AutoConfiguration order is incorrect (apache#5092)
  optimize: lock priority attempts to insert (apache#4681)
  bugfix: update join condition placeholder param error (apache#5052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants