-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: support oracle nclob types #4543
Merged
slievrly
merged 70 commits into
apache:develop
from
doubleDimple:support_oracle_binaryTypes_4537
Sep 6, 2022
Merged
bugfix: support oracle nclob types #4543
slievrly
merged 70 commits into
apache:develop
from
doubleDimple:support_oracle_binaryTypes_4537
Sep 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/io/seata/core/console/result/PageResult.java # server/src/main/java/io/seata/server/storage/SessionConverter.java
Codecov Report
@@ Coverage Diff @@
## develop #4543 +/- ##
=============================================
+ Coverage 49.03% 49.20% +0.17%
- Complexity 4087 4107 +20
=============================================
Files 736 736
Lines 25784 25784
Branches 3180 3180
=============================================
+ Hits 12642 12686 +44
+ Misses 11799 11754 -45
- Partials 1343 1344 +1
|
DB: oracle 19c
|
funky-eyes
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
slievrly
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
解决AT模式下oracle不支持NCLOB
Ⅱ. Does this pull request fix one issue?
fixes #4537
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews