-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize : tccfence log table deleted should be optimized #4490
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4490 +/- ##
=============================================
- Coverage 49.12% 49.06% -0.06%
- Complexity 4095 4097 +2
=============================================
Files 737 737
Lines 25790 25827 +37
Branches 3189 3193 +4
=============================================
+ Hits 12669 12672 +3
- Misses 11772 11808 +36
+ Partials 1349 1347 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* The constant QUERY_END_STATUS_BY_DATE. | ||
*/ | ||
protected static final String QUERY_END_STATUS_BY_DATE = "select xid, branch_id, status, gmt_create, gmt_modified " | ||
+ "from " + LOCAL_TCC_LOG_PLACEHOLD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Later Please submit a PR for Oracle and other databases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seata-go: apache/incubator-seata-go#699 |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
#4489
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews