refactor: remove unused unit tests in pegasus_write_service_impl_test #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
approved these changes
Jan 8, 2021
hycdong
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
I will remove
write_batch_putandwrite_batch_put_ctxin pegasus_write_service_impl.h. And there are tests in rocksdb_wrapper_test.cpp to testrockdb_wrapper::write_batch_putandrocksdb_wrapper::write_batch_put_ctx, which are substitutes for the functions with same name in pegasus_write_service_impl.h. So the unit tests in pegasus_write_service_impl_test forpegasus_write_service::impl::write_batch_putandpegasus_write_service::impl::write_batch_put_ctxare useless.Check List
Tests