-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use rocksdb_wrapper::write_batch_put to reimplement check_and_set #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Dec 15, 2020
acelyc111
reviewed
Dec 16, 2020
acelyc111
previously approved these changes
Dec 24, 2020
neverchanje
reviewed
Dec 29, 2020
Comment on lines
+74
to
+77
std::unique_ptr<pegasus_value_generator> _value_generator; | ||
std::unique_ptr<rocksdb::WriteBatch> _write_batch; | ||
std::unique_ptr<rocksdb::WriteOptions> _wt_opts; | ||
rocksdb::ColumnFamilyHandle *_meta_cf; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
std::unique_ptr<pegasus_value_generator> _value_generator; | |
std::unique_ptr<rocksdb::WriteBatch> _write_batch; | |
std::unique_ptr<rocksdb::WriteOptions> _wt_opts; | |
rocksdb::ColumnFamilyHandle *_meta_cf; | |
pegasus_value_generator _value_generator; | |
rocksdb::WriteBatch _write_batch; | |
rocksdb::WriteOptions _wt_opts; | |
rocksdb::ColumnFamilyHandle *_meta_cf; |
Why not use value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reduce file dependencies
neverchanje
approved these changes
Dec 29, 2020
hycdong
approved these changes
Dec 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
use rocksdb_wrapper::write_batch_put to reimplement check_and_set
Check List
Tests