feat(hotkey): add unit test of hotkey collector #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Dec 3, 2020
Comment on lines
+313
to
+332
| on_detect_hotkey(generate_control_rpc(dsn::replication::hotkey_type::READ, | ||
| dsn::replication::detect_action::START), | ||
| resp); | ||
| ASSERT_EQ(resp.err, dsn::ERR_OK); | ||
| ASSERT_EQ(get_collector_stat(collector), hotkey_collector_state::COARSE_DETECTING); | ||
|
|
||
| for (int i = 0; i < 1000; i++) { | ||
| dsn::tasking::enqueue(LPC_WRITE, &_tracker, [&] { | ||
| _server->on_get(generate_get_rpc(generate_hash_key_by_random(false))); | ||
| }); | ||
| } | ||
| collector->analyse_data(); | ||
| ASSERT_EQ(get_collector_stat(collector), hotkey_collector_state::COARSE_DETECTING); | ||
|
|
||
| on_detect_hotkey(generate_control_rpc(dsn::replication::hotkey_type::READ, | ||
| dsn::replication::detect_action::STOP), | ||
| resp); | ||
| ASSERT_EQ(resp.err, dsn::ERR_OK); | ||
| ASSERT_EQ(get_collector_stat(collector), hotkey_collector_state::STOPPED); | ||
| _tracker.wait_outstanding_tasks(); |
There was a problem hiding this comment.
This entire block of tests are redundant. It repeates the previous lines, from STOPPED to COARSE_DETECTING, and STOPPED. You don't have to repeat.
There was a problem hiding this comment.
https://github.com/apache/incubator-pegasus/pull/648/files/b7927974330ad1b93d5f28cd2b798d2e7ce2d244#diff-d16dd94725655577d994a6cb037e9e369e6ddcd03f4c5fdbe6dfd99d69362236R321
this block is to test the state transform in normal data
https://github.com/apache/incubator-pegasus/pull/648/files/b7927974330ad1b93d5f28cd2b798d2e7ce2d244#diff-d16dd94725655577d994a6cb037e9e369e6ddcd03f4c5fdbe6dfd99d69362236R287
And the previous block is to test it in hotspot data
added 3 commits
December 4, 2020 11:43
levy5307
reviewed
Dec 8, 2020
neverchanje
approved these changes
Dec 8, 2020
levy5307
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.