feat(hotkey): add thread_safe method to clear collector #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Nov 9, 2020
Co-authored-by: Yingchun Lai <[email protected]>
levy5307
reviewed
Nov 9, 2020
| @@ -332,5 +339,12 @@ void hotkey_fine_data_collector::analyse_data(detect_hotkey_result &result) | |||
| } | |||
| } | |||
|
|
|||
| void hotkey_fine_data_collector::clear() | |||
| { | |||
| std::pair<dsn::blob, uint64_t> key_weight_pair; | |||
There was a problem hiding this comment.
what about change it like this?
moodycamel::ConcurrentQueue<std::pair<dsn::blob, uint64_t>> temp;
_capture_key_queue.swap(temp);
There was a problem hiding this comment.
concurrentqueue.h:890
// Swaps this queue's state with the other's. Not thread-safe.
// Swapping two queues does not invalidate their tokens, however
// the tokens that were created for one queue must be used with
// only the swapped queue (i.e. the tokens are tied to the
// queue's movable state, not the object itself).
It's not a thread safe way
acelyc111
reviewed
Nov 9, 2020
| @@ -102,6 +102,7 @@ class internal_collector_base : public dsn::replication::replica_base | |||
| explicit internal_collector_base(replica_base *base) : replica_base(base){}; | |||
| virtual void capture_data(const dsn::blob &hash_key, uint64_t weight) = 0; | |||
| virtual void analyse_data(detect_hotkey_result &result) = 0; | |||
| virtual void clear() = 0; | |||
There was a problem hiding this comment.
acelyc111
approved these changes
Nov 10, 2020
neverchanje
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.