refactor: remove some useless configs #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
changed the title
added 5 commits
June 15, 2019 16:28
qinzuoyan
reviewed
Jun 16, 2019
3 tasks
qinzuoyan
approved these changes
Jun 17, 2019
hycdong
approved these changes
Jun 17, 2019
Closed
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
Former-commit-id: b05475bc0d7a15015c5317956bb444b40967f873 [formerly 3c59ffd] Former-commit-id: 4c1096f215f71ac17d556f15df58939b6c6bfe8a
neverchanje
pushed a commit
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The configurations
max_input_queue_lengthhpc_loggercli_localcli_remoteupdating_rocksdb_sstsize_interval_secondsstart_nfsfast_execution_in_network_threadfast_runalready have no codes related.
Previously @qinzuoyan had cleared
max_input_queue_lengthfrom rdsn: XiaoMi/rdsn#191@shengofsun has cleared
cli_localandcli_remotefrom rdsn: XiaoMi/rdsn#156@acelyc111 has changed
updating_rocksdb_sstsize_interval_secondstoupdate_rdb_stat_interval#212@shengofsun has cleared
start_nfsfrom rdsn: XiaoMi/rdsn#142@qinzuoyan has cleared
fast_execution_in_network_threadfrom rdsn in 2016: XiaoMi/rdsn@2e43e94fast_runwas removed in XiaoMi/rdsn#117This time I do the same thing in Pegasus.
What is changed and how it works?
Check List
Tests
Related changes