Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script: enforce rolling update to be run in tmux. #296

Merged
merged 1 commit into from
Mar 4, 2019
Merged

script: enforce rolling update to be run in tmux. #296

merged 1 commit into from
Mar 4, 2019

Conversation

neverchanje
Copy link
Contributor

No description provided.

@qinzuoyan
Copy link
Contributor

这个没必要吧，怎么运行是使用者的事情，他可能也用 nohup 放到后台运行。

@neverchanje
Copy link
Contributor Author

@qinzuoyan 主要是避免网络断了，或者 SRE 晚上升级不小心睡着的情况

@qinzuoyan
Copy link
Contributor

这。。。好吧，强制也是一个办法。

@qinzuoyan qinzuoyan merged commit 45c6f1e into apache:master Mar 4, 2019
@neverchanje neverchanje mentioned this pull request Jun 11, 2019
Closed
24 tasks
neverchanje pushed a commit that referenced this pull request Jun 14, 2019
script: enforce rolling update to be run in tmux. (#296)
b36b2e7
@neverchanje neverchanje mentioned this pull request Jun 21, 2019
Closed
19 tasks
neverchanje pushed a commit that referenced this pull request Jun 21, 2019
script: enforce rolling update to be run in tmux. (#296)
fa485bd
neverchanje pushed a commit that referenced this pull request Jul 1, 2019
script: enforce rolling update to be run in tmux. (#296)
55e4086
neverchanje pushed a commit to neverchanje/pegasus that referenced this pull request Jul 13, 2019
@qinzuoyan
script: enforce rolling update to be run in tmux. (apache#296)
8854aac 
Former-commit-id: 4e9c113c08418bebd52011404f576db659b080ae [formerly 45c6f1e]
Former-commit-id: c446c3e8272ed5f99acf56be9441f9ddc02203e2
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
http: improvement on http api (#296)
a9ab6c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@qinzuoyan qinzuoyan qinzuoyan approved these changes

@acelyc111 acelyc111 Awaiting requested review from acelyc111

@hycdong hycdong Awaiting requested review from hycdong

@mentoswang mentoswang Awaiting requested review from mentoswang

Assignees
No one assigned
Labels
1.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neverchanje @qinzuoyan @vagetablechicken