Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell: copy_data command supports filter #271

Merged
merged 7 commits into from
Feb 15, 2019
Merged

shell: copy_data command supports filter #271

merged 7 commits into from
Feb 15, 2019

Conversation

qinzuoyan
Copy link
Contributor

improve shell's copy_data command:

  • support HashKey/SortKey/Value filters
  • support only copy one partition by --partition option
  • support not overwrite data (only set if not exist) by --no_overwrite option

@qinzuoyan qinzuoyan added the component/shell pegasus shell label Jan 30, 2019
@qinzuoyan qinzuoyan self-assigned this Jan 30, 2019
neverchanje
neverchanje reviewed Feb 15, 2019
View reviewed changes
src/shell/command_helper.h Outdated
@@ -101,6 +102,9 @@ struct scan_data_context
int split_id;
int max_batch_count;
int timeout_ms;
bool no_overwrite; // for copy_data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该加一行注释 "uses check_and_set instead of using set for insertion"，单看这个选项不容易看明白

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improved

neverchanje
neverchanje previously approved these changes Feb 15, 2019
View reviewed changes
@qinzuoyan qinzuoyan requested a review from mentoswang February 15, 2019 08:38
@qinzuoyan qinzuoyan merged commit 7314ec1 into master Feb 15, 2019
@qinzuoyan qinzuoyan deleted the qinzuoyan branch February 15, 2019 09:37
qinzuoyan added a commit that referenced this pull request Feb 27, 2019
@qinzuoyan
shell: copy_data command supports filter (#271)
3f59db6
neverchanje pushed a commit to neverchanje/pegasus that referenced this pull request Jul 13, 2019
@qinzuoyan
shell: copy_data command supports filter (apache#271)
1007503 
Former-commit-id: cc19a265e963e04b85b803b2743c515f70b7dae0 [formerly 7314ec1]
Former-commit-id: 4572a781737f2405934ac0522a66944937a1a50d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mentoswang mentoswang mentoswang approved these changes

@neverchanje neverchanje neverchanje approved these changes

@acelyc111 acelyc111 Awaiting requested review from acelyc111

@hycdong hycdong Awaiting requested review from hycdong

Assignees

@qinzuoyan qinzuoyan

Labels
component/shell pegasus shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinzuoyan @neverchanje @mentoswang