monitor: expose rocksdb statistics to pegasus #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
reviewed
Nov 12, 2018
src/shell/commands.h
Outdated
| << std::setw(w) << std::right << "abnormal" << std::setw(w) << std::right << "file_mb" | ||
| << std::setw(w) << std::right << "file_num"; | ||
| << std::setw(w) << std::right << "abnormal" << std::setw(w) << std::right | ||
| << "file_size(MB)" << std::setw(w) << std::right << "file_num" << std::setw(w) |
There was a problem hiding this comment.
file_size(MB) -> file_mb
mem_usage(MB) -> memtbl_mb
There was a problem hiding this comment.
mem_usage(MB) -> memtbl_mb改成rdb_mem_mb吧，他除了包含memtable，还包含index_and_filter_blocks占用的内存
qinzuoyan
reviewed
Nov 12, 2018
qinzuoyan
previously approved these changes
Nov 13, 2018
neverchanje
reviewed
Nov 13, 2018
neverchanje
reviewed
Nov 13, 2018
| _updating_rocksdb_sstsize_timer_task = nullptr; | ||
| if (_update_replica_rdb_stat != nullptr) { | ||
| _update_replica_rdb_stat->cancel(true); | ||
| _update_replica_rdb_stat = nullptr; | ||
| } |
There was a problem hiding this comment.
新加的 _update_server_rdb_stat 是不是也要 cancel ？
There was a problem hiding this comment.
_update_server_rdb_stat是全局的，不cancel，他的生命周期跟进程对应，而_update_replica_rdb_stat生命周期跟replica对应
neverchanje
approved these changes
Nov 13, 2018
qinzuoyan
approved these changes
Nov 13, 2018
|
对了，忘记说了：更新下update screen脚本，把新counter加入到screen里面？ |
acelyc111
added a commit
that referenced
this pull request
Dec 14, 2018
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
Former-commit-id: 33104d37ded07ba4a8827e70a3624a61822599fb [formerly 9e58867] Former-commit-id: 24398d7ac3a9944138b3aea065150353b55aadf2
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#184