idl: fix recompile_thrift.sh & script: add format_files.sh #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagetablechicken
requested review from
neverchanje,
acelyc111,
qinzuoyan,
hycdong,
mentoswang and
zhangyifan27
and removed request for
neverchanje and
acelyc111
qinzuoyan
previously approved these changes
Nov 1, 2018
mentoswang
previously approved these changes
Nov 1, 2018
|
good job! but linenoise and sds should be excluded from clang-format, it's a thirdparty code, we should keep its code style. |
neverchanje
reviewed
Nov 1, 2018
scripts/format-files.sh
Outdated
| @@ -0,0 +1,16 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
format_files.sh, we use userline for file name
neverchanje
reviewed
Nov 1, 2018
src/idl/recompile_thrift.sh
Outdated
| sh $DSN_ROOT/bin/dsn.cg.sh rrdb.thrift cpp $TMP_DIR | ||
| cp -v $TMP_DIR/rrdb.types.h ../include/rrdb/ | ||
| $DSN_ROOT/bin/Linux/thrift --gen cpp:moveable_types -out $TMP_DIR rrdb.thrift | ||
| #cp -v $TMP_DIR/rrdb.types.h ../include/rrdb/ |
There was a problem hiding this comment.
remove out the commented codes
vagetablechicken
dismissed stale reviews from mentoswang and qinzuoyan
via
e6d8e1e
vagetablechicken
force-pushed
the
master
branch
from
14e078f to
e6d8e1e
Compare
neverchanje
previously approved these changes
Nov 1, 2018
qinzuoyan
previously approved these changes
Nov 1, 2018
vagetablechicken
dismissed stale reviews from qinzuoyan and neverchanje
via
dbe064d
|
@neverchanje already exclude rocksdb/，linenoise/，sds/ from formating |
neverchanje
approved these changes
Nov 2, 2018
hycdong
approved these changes
Nov 2, 2018
neverchanje
changed the title
acelyc111
pushed a commit
that referenced
this pull request
Dec 14, 2018
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
Former-commit-id: ea5edf13a0d9d9b8e05013b5e2008a88141ba53e [formerly 2544463] Former-commit-id: 28fc55e542626308088b1db739bdb4309adace9c
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.