shell: add ddd_diagnose command #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Sep 5, 2018
|
|
||
| std::cout << "Diagnose ddd done." << std::endl; | ||
| return true; | ||
| } |
acelyc111
reviewed
Sep 5, 2018
| std::ofstream of; | ||
|
|
||
| if (!out_file.empty()) { | ||
| of.open(out_file); |
There was a problem hiding this comment.
不用自己close，对象析构时会自动close
acelyc111
previously approved these changes
Sep 5, 2018
neverchanje
reviewed
Sep 5, 2018
| @@ -4310,3 +4310,228 @@ inline bool clear_app_envs(command_executor *e, shell_context *sc, arguments arg | |||
| } | |||
| return true; | |||
| } | |||
|
|
|||
| inline dsn::rpc_address diagnose_recommend(const ddd_partition_info &pinfo) | |||
There was a problem hiding this comment.
加个注释吧
// Select a best node to be the new primary after a DDD situation, following the rule:
// - choose the node with largest committed decree
// - if committed decree is the same, choose the node with largest ballot
不知道规则有没有理解对，另外在 pr description 里面描述一下 DDD 推荐的规则吧，以后也可以写到文档里
neverchanje
previously approved these changes
Sep 6, 2018
neverchanje
approved these changes
Sep 6, 2018
acelyc111
approved these changes
Sep 6, 2018
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
Former-commit-id: ce30d9dfc6c1569ec8700e6aad80059488cb8367 [formerly c27a6c0] Former-commit-id: c40267ccd9ea34a00ca764df88908842acd1c826
cauchy1988
added a commit
to cauchy1988/incubator-pegasus
that referenced
this pull request
May 7, 2022
… read optimization (apache#175)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to XiaoMi/rdsn#80