Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): fix build failure of rocksdb when PORTABLE=0 #1607

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix(docker): fix build failure of rocksdb when PORTABLE=0 #1607

merged 2 commits into from
Sep 14, 2023

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Sep 14, 2023 •
edited
Loading

#1604

Explicit set PORTABLE=native to avoid building failure. The failure looks like:

cc1plus: error: bad value ('OFF') for '-march=' switch
cc1plus: note: valid arguments to '-march=' switch are: nocona core2 nehalem corei7
    westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell
    skylake skylake-avx512 bonnell atom silvermont slm knl x86-64 eden-x2 nano nano-1000
    nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64
    athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 btver1
    btver2

@acelyc111 acelyc111 changed the title fix(docker): fix build failure of ROCKSDB_PORTABLE=0 fix(docker): fix build failure of rocksdb when PORTABLE=0 Sep 14, 2023
@acelyc111 acelyc111 merged commit b15d577 into master Sep 14, 2023
91 of 92 checks passed
@acelyc111 acelyc111 deleted the dockerfile_rdb_native branch September 14, 2023 17:21
@acelyc111 acelyc111 mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smityz Smityz Smityz approved these changes

@levy5307 levy5307 levy5307 approved these changes

@empiredan empiredan Awaiting requested review from empiredan

Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acelyc111 @levy5307 @Smityz