Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knife4j by a new module named linkis-knif4j #2366

Merged
merged 6 commits into from
Jul 4, 2022

Conversation

WenxiangFan
Copy link
Contributor

What is the purpose of the change

Add knife4j by a new module

Brief change log

-Create a new module named linikis-knif4j
-Add the dependency of the linikis-knif4j module in “assembly-combined-package/assembly-combined/public-module-combined/pom.xml”
-Linikis-knif4j will be packaged in the "lib/links-commons/public-module/" path.

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

  • Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) yes
  • Anything that affects deployment: (yes / no / don't know) no
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (yes / no) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@WenxiangFan WenxiangFan changed the title Dev 1.2.0 Add knife4j by a new module named linkis-knif4j Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #2366 (3255d26) into dev-1.2.0 (10ee01d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.2.0    #2366      +/-   ##
===============================================
- Coverage        17.83%   17.82%   -0.02%     
+ Complexity        1077     1076       -1     
===============================================
  Files              595      595              
  Lines            17667    17667              
  Branches          2635     2635              
===============================================
- Hits              3151     3149       -2     
- Misses           14092    14093       +1     
- Partials           424      425       +1     
Impacted Files Coverage Δ
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 35.55% <0.00%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ee01d...3255d26. Read the comment docs.

@peacewong peacewong mentioned this pull request Jun 29, 2022
@casionone casionone merged commit b462730 into apache:dev-1.2.0 Jul 4, 2022
@casionone casionone mentioned this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants