Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built-in variables run_today_h and run_today_h_std #2299

Merged
merged 4 commits into from
Jun 20, 2022

Conversation

peacewong
Copy link
Contributor

What is the purpose of the change

close #2179

Brief change log

  • Add built-in variables run_today_h and run_today_h_std

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

  • Add custom variable test class

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #2299 (f59fe6a) into dev-1.2.0 (caccf89) will increase coverage by 1.88%.
The diff coverage is 77.92%.

@@               Coverage Diff               @@
##             dev-1.2.0    #2299      +/-   ##
===============================================
+ Coverage        20.56%   22.45%   +1.88%     
- Complexity        1055     1061       +6     
===============================================
  Files              455      455              
  Lines            13920    13963      +43     
  Branches          2192     2200       +8     
===============================================
+ Hits              2863     3135     +272     
+ Misses           10668    10390     -278     
- Partials           389      438      +49     
Impacted Files Coverage Δ
...g/apache/linkis/common/variable/VariableType.scala 17.80% <33.33%> (+17.80%) ⬆️
...apache/linkis/common/variable/CustomDateType.scala 57.62% <50.00%> (+57.62%) ⬆️
.../apache/linkis/common/variable/DateTypeUtils.scala 74.78% <80.00%> (+74.78%) ⬆️
...org/apache/linkis/common/utils/VariableUtils.scala 60.11% <100.00%> (+60.11%) ⬆️
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 34.44% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caccf89...f59fe6a. Read the comment docs.

Copy link
Member

@utopianet utopianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casionone casionone merged commit f8cbf45 into apache:dev-1.2.0 Jun 20, 2022
@peacewong peacewong deleted the dev-1.2.0-runt_tode_h branch June 22, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants