Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 1.2.0 (add test case for jdbc engine) #2278

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Dev 1.2.0 (add test case for jdbc engine) #2278

merged 2 commits into from
Jun 14, 2022

Conversation

QuintinTao
Copy link
Contributor

add test case for jdbc engine

  • Added tests for JDBCEngineConnExecutor.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #2278 (804fdf7) into dev-1.2.0 (740d015) will increase coverage by 0.73%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.2.0    #2278      +/-   ##
===============================================
+ Coverage        19.63%   20.37%   +0.73%     
- Complexity         865     1041     +176     
===============================================
  Files              396      454      +58     
  Lines            12361    13797    +1436     
  Branches          1819     2177     +358     
===============================================
+ Hits              2427     2811     +384     
- Misses            9675    10599     +924     
- Partials           259      387     +128     
Impacted Files Coverage Δ
...ngineplugin/jdbc/JDBCDataSourceConfigurations.java 18.18% <0.00%> (-1.82%) ⬇️
...linkis/jobhistory/restful/api/QueryRestfulApi.java 42.20% <0.00%> (-0.52%) ⬇️
...inkis/jobhistory/conversions/TaskConversions.scala 8.37% <0.00%> (-0.20%) ⬇️
.../org/apache/linkis/common/conf/Configuration.scala 0.00% <0.00%> (ø)
...org/apache/linkis/common/utils/VariableUtils.scala 0.00% <0.00%> (ø)
...is/manager/engineplugin/jdbc/PropertiesParser.java 62.50% <0.00%> (ø)
...a/org/apache/linkis/scheduler/event/LogEvent.scala 50.00% <0.00%> (ø)
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 34.44% <0.00%> (ø)
...kis/ecm/core/launch/ProcessEngineCommandExec.scala 0.00% <0.00%> (ø)
...e/linkis/scheduler/executer/AbstractExecutor.scala 0.00% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740d015...804fdf7. Read the comment docs.

Copy link
Contributor

@CCweixiao CCweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看有些测试方法连接的是你自己的mysql,在自己开发环境OK,但在GitHub check时有可能会报错,请再确认下。

I see that some test methods are connected to your own mysql, which is OK in your own development environment, but may report an error when checking on GitHub, please confirm again.

@CCweixiao CCweixiao merged commit e1c5f84 into apache:dev-1.2.0 Jun 14, 2022
@QuintinTao QuintinTao deleted the dev-1.2.0 branch July 6, 2022 01:34
@QuintinTao QuintinTao restored the dev-1.2.0 branch July 6, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants