Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in the workspace, files can be moved to another folder #2277

Merged
merged 3 commits into from
Jun 15, 2022

Conversation

liangqilang
Copy link
Contributor

What is the purpose of the change
in the workspace, files can be moved to another folder

Brief change log
This feature is added to this class FsRestfulApi

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): (no)
Anything that affects deployment: (no)
The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: ( no)
Documentation
Does this pull request introduce a new feature? (no)

in the workspace, files can be moved to another folder
in the workspace, files can be moved to another folder
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #2277 (92b3aa2) into dev-1.2.0 (ae61ee9) will increase coverage by 0.22%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.2.0    #2277      +/-   ##
===============================================
+ Coverage        20.14%   20.36%   +0.22%     
- Complexity        1031     1040       +9     
===============================================
  Files              454      454              
  Lines            13797    13797              
  Branches          2177     2177              
===============================================
+ Hits              2779     2810      +31     
+ Misses           10634    10600      -34     
- Partials           384      387       +3     
Impacted Files Coverage Δ
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 33.33% <0.00%> (-1.12%) ⬇️
...s/manager/engineplugin/jdbc/ConnectionManager.java 43.12% <0.00%> (+1.89%) ⬆️
...eplugin/jdbc/executer/JDBCEngineConnExecutor.scala 12.98% <0.00%> (+12.98%) ⬆️
...ineplugin/jdbc/factory/JDBCEngineConnFactory.scala 50.00% <0.00%> (+50.00%) ⬆️
...ger/engineplugin/jdbc/conf/JDBCConfiguration.scala 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae61ee9...92b3aa2. Read the comment docs.

throw WorkspaceExceptionManager.createException(80004, newDir);
}
FsPath flieOldPath = new FsPath(filePath);
// 获取文件名
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to remove Chinese

null value judgment and remove Chinese
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit e86a185 into apache:dev-1.2.0 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants