-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in the workspace, files can be moved to another folder #2277
in the workspace, files can be moved to another folder #2277
Conversation
in the workspace, files can be moved to another folder
in the workspace, files can be moved to another folder
Codecov Report
@@ Coverage Diff @@
## dev-1.2.0 #2277 +/- ##
===============================================
+ Coverage 20.14% 20.36% +0.22%
- Complexity 1031 1040 +9
===============================================
Files 454 454
Lines 13797 13797
Branches 2177 2177
===============================================
+ Hits 2779 2810 +31
+ Misses 10634 10600 -34
- Partials 384 387 +3
Continue to review full report at Codecov.
|
...e-script-dev-server/src/main/java/org/apache/linkis/filesystem/restful/api/FsRestfulApi.java
Show resolved
Hide resolved
throw WorkspaceExceptionManager.createException(80004, newDir); | ||
} | ||
FsPath flieOldPath = new FsPath(filePath); | ||
// 获取文件名 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended to remove Chinese
null value judgment and remove Chinese
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
in the workspace, files can be moved to another folder
Brief change log
This feature is added to this class FsRestfulApi
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): (no)
Anything that affects deployment: (no)
The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: ( no)
Documentation
Does this pull request introduce a new feature? (no)