[VL] Wrong result when cast(double as decimal) with gluten code: branch-1.1

[kecookier]

Backend

VL (Velox)

Bug description

The following unittest can reproduce this issue.
I test this in branch-1.1, and not sure if this issue still exists in the branch-1.1.1.

TEST_F(CastExprTest, myTestDouble2Decimal) {
  testComplexCast(
      "c0",
      makeFlatVector<double>({0.0, 0.575}),
      makeFlatVector<int128_t>({0, 58}, DECIMAL(20, 2)));
}

Spark version

None

Spark configurations

No response

System information

No response

Relevant logs

/root/gluten/ep/build-velox/build/velox_ep/velox/vector/tests/utils/VectorTestBase.cpp:151: Failure
Value of: expected->equalValueAt(actual.get(), i, i)
  Actual: false
Expected: true
at 1: expected 0.58, but got 0.57

[kecookier]

hi @rui-mo, Can you help fix this issue?

[rui-mo]

@kecookier OK, I'll take a look.

[rui-mo]

@kecookier This issue does not exist on the main branch, as we recently merged a fix to the precision issue of cast(double as decimal). Just verified below test on main.

TEST_F(CastExprTest, myTestDouble2Decimal) {
  testCast(
      makeFlatVector<double>({0.0, 0.575}),
      makeFlatVector<int128_t>({0, 58}, DECIMAL(20, 2)));
}

[kecookier]

@rui-mo Could you provide the PR for the fix? I'd like to cherry-pick it for testing.

[rui-mo]

@kecookier Please take a try with facebookincubator/velox#8575.

[kecookier]

@rui-mo I've test this PR in release-1.1, it has fixed the issue.
Thanks for your help.