Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Some suggestions for eventmesh-examples. #785

Closed
1 task done
Alonexc opened this issue Feb 23, 2022 · 1 comment
Closed
1 task done

[Enhancement] Some suggestions for eventmesh-examples. #785

Alonexc opened this issue Feb 23, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Feb 23, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Question

image

These constants are used in multiple classes and are proposed to be placed in a Constant class.

image

Located in:eventmesh-examples/src/main/java/org/apache/eventmesh/tcp/demo/pub/eventmeshmessage/SyncRequest.java and eventmesh-examples/src/main/java/org/apache/eventmesh/tcp/demo/sub/eventmeshmessage/SyncResponse.java
You are advised to obtain it by reading the configuration file.
Such as:
Screen Shot 2022-02-23 at 16 21 07

Invalid code in AsyncSubscribe class can be removed.
image

@Alonexc Alonexc added the question Further information is requested label Feb 23, 2022
@xwm1992 xwm1992 added this to the 1.4.0 milestone Feb 23, 2022
@likegeek
Copy link
Contributor

please let me try

@xwm1992 xwm1992 added enhancement New feature or request and removed question Further information is requested labels Feb 24, 2022
@xwm1992 xwm1992 changed the title [Question] Some suggestions for eventmesh-examples [Enhancement] Some suggestions for eventmesh-examples. Feb 24, 2022
@xwm1992 xwm1992 closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants