Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc][Link] Links in the website are deprecated #595

Open
d4x1 opened this issue Jul 20, 2023 · 7 comments
Open

[Doc][Link] Links in the website are deprecated #595

d4x1 opened this issue Jul 20, 2023 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@d4x1
Copy link
Contributor

d4x1 commented Jul 20, 2023

Documentation Scope

This repo's github action fails every day, cause of deprecated links in the website's document.

Describe the Change

After checking the errors, I found that link to code like https://github.com/apache/incubator-devlake/blob/main/generator/template/plugin/tasks/task_data.go-template should be https://github.com/apache/incubator-devlake/blob/main/backend/generator/template/plugin/tasks/task_data.go-template. (Just add a /backend in the file path.)

Screenshots

image

Additional context

Other 404 links are unexpected, we can fix the links to code details, and see what happends to this checker.

@Startrekzky Startrekzky added the good first issue Good for newcomers label Jul 24, 2023
@kushan23
Copy link

Hi, if it's possible can i work on it? Is it still open?

@d4x1
Copy link
Contributor Author

d4x1 commented Aug 18, 2023

@kushan23 Of course ! thank you!

@klesh
Copy link
Contributor

klesh commented Aug 18, 2023

@kushan23 Yes, it is. Thanks for volunteering.

@anjy7
Copy link
Contributor

anjy7 commented Sep 8, 2023

Looks like @kushan23 isn't working on this. May I work on this @klesh ?

@klesh
Copy link
Contributor

klesh commented Sep 11, 2023

@anjy7 Yup, sure. Thanks for volunteering

@klesh klesh assigned anjy7 and unassigned kushan23 Sep 11, 2023
@anjy7
Copy link
Contributor

anjy7 commented Sep 18, 2023

hey @klesh , there's no https://github.com/apache/incubator-devlake/blob/main/backend/generator/template/plugin/tasks/task_data.go-template (mentioned as a fix above ) isn't a valid url as there's no generator folder. Any guidance on how to proceed with those links which were under generator?

@klesh
Copy link
Contributor

klesh commented Sep 19, 2023

@anjy7 Hi, code generator has been deprecated recently.
I think you are fixing the link from an older version, in this case, you should select the version accordingly on the repo, and then you can find the missing file with the correct link.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants