Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumPy Hardpin 1.26 issue #1198

Closed
anuraggautam14 opened this issue Sep 24, 2024 · 2 comments · Fixed by #1270
Closed

NumPy Hardpin 1.26 issue #1198

anuraggautam14 opened this issue Sep 24, 2024 · 2 comments · Fixed by #1270
Assignees

Comments

@anuraggautam14
Copy link

Apache Iceberg version

0.7.1 (latest release)

Please describe the bug 🐞

issue :
In the latest version (0.7.1) , we notice that NumPy is hard-pinned at 1.26 (pyproject.toml link below)
https://github.com/apache/iceberg-python/blob/main/pyproject.toml#L82-L85

This is causing dependency issue in our environment where our other libraries need NumPy > 2

Expected Behaviour:

We expect NumPy to be flex pin to >= 1.26.4 < 3

@sungwy
Copy link
Collaborator

sungwy commented Sep 24, 2024

Hi @anuraggautam14 thanks for raising this issue.

This was actually intentionally imposed to solve an issue with pandas and numpy version compatibility. I'll take another pass at this to see if we can be more graceful about our version dependency here

@sungwy sungwy self-assigned this Sep 24, 2024
@Fokko
Copy link
Contributor

Fokko commented Oct 30, 2024

I think we can remove the numpy dependency completely once we get #1259 fixed. This will give flexibility to the user on which version to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants