Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bugs. change nacos monitor to prometheus. #880

Merged
merged 6 commits into from
Apr 18, 2023
Merged

fixed bugs. change nacos monitor to prometheus. #880

merged 6 commits into from
Apr 18, 2023

Conversation

leo-934
Copy link
Contributor

@leo-934 leo-934 commented Apr 14, 2023

fixed bugs occurred when there are two consecutive slashes in prometheus response. #872
change nacos monitor from json to prometheus.
add prometheus test。

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

…eus response.

change nacos monitor from json to prometheus.
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Apr 14, 2023
@Ceilzcx Ceilzcx changed the base branch from master to dev April 15, 2023 01:58
@Ceilzcx Ceilzcx requested a review from tomsun28 April 15, 2023 01:59
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

manager/src/main/resources/define/app-nacos.yml Outdated Show resolved Hide resolved
manager/src/main/resources/define/app-nacos.yml Outdated Show resolved Hide resolved
@leo-934 leo-934 merged commit d45bf8e into apache:dev Apr 18, 2023
tomsun28 added a commit that referenced this pull request Jan 16, 2024
* fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

* add prometheus test

---------

Signed-off-by: vinci <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
* fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

* add prometheus test

---------

Signed-off-by: vinci <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
* fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

* add prometheus test

---------

Signed-off-by: vinci <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
  fixed bugs occurred when there are two consecutive slashes in prometheus response.
change nacos monitor from json to prometheus.

  add prometheus test

---------

Signed-off-by: vinci <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants