Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Add test for FtpCollectImpl #1856

Merged
merged 5 commits into from
Apr 26, 2024
Merged

[test] Add test for FtpCollectImpl #1856

merged 5 commits into from
Apr 26, 2024

Conversation

crossoverJie
Copy link
Member

@crossoverJie crossoverJie commented Apr 26, 2024 •
edited
Loading

What's changed?

  • Add test for FtpCollectImpl.
  • Add a new setter method for testing.
  • Add timeout check.
  • Move the setControlKeepAliveReplyTimeout method after calling preCheck.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 26, 2024
tomsun28
tomsun28 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@tomsun28 tomsun28 merged commit 025a7d9 into apache:master Apr 26, 2024
3 checks passed
@crossoverJie crossoverJie deleted the ftp-test branch April 26, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend collector good first pull request Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crossoverJie @tomsun28