Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] translates chinese comment to english. #1853

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

dukbong
Copy link
Contributor

@dukbong dukbong commented Apr 26, 2024

What's changed?

This pull request translates Chinese to English.

Question.

It looks like many methods are recording the start time and measuring the response time. Could I get your thoughts on using AOP to store the start time in ThreadLocal when entering the method, then using that to handle response time calculations? I'm still learning, so I'd appreciate your advice.

If it's okay, I'd like to give it a try.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28
Copy link
Contributor

hi, can you tell me which method? AOP may not be suitable in some places.

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28 tomsun28 changed the title Translates Chinese to English. [doc] translates chinese comment to english. Apr 26, 2024
@tomsun28 tomsun28 merged commit 9545c8d into apache:master Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants