Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Split the WarehouseProperties class #1830

Merged
merged 2 commits into from
Apr 25, 2024
Merged

[refactor] Split the WarehouseProperties class #1830

merged 2 commits into from
Apr 25, 2024

Conversation

xuziyang
Copy link
Contributor

@xuziyang xuziyang commented Apr 24, 2024 •
edited
Loading

What's changed?

WarehouseProperties split into multiple classes #1829

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@zqr10159 zqr10159 requested review from tomsun28 and Ceilzcx April 24, 2024 07:05
@tomsun28 tomsun28 linked an issue Apr 25, 2024 that may be closed by this pull request
Split the WarehouseProperties class #1829
Closed
tomsun28
tomsun28 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28 tomsun28 merged commit 41de1b9 into apache:master Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

@Ceilzcx Ceilzcx Awaiting requested review from Ceilzcx

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split the WarehouseProperties class
2 participants
@xuziyang @tomsun28