Code Simplification, Structure Changes, and Translation Work, Along with a Question #1827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Description
This PR simplifies the code by using Assert methods and changes the location of the
validateParams()
process.By moving this process,
validateParams()
can perform a null check earlier.Question
In the JmxCollectImpl code, the
getConnectSession()
checks whetherjmxProtocol.getUrl() != null
, which is already validated invalidateParams()
.This redundancy seems unnecessary, but I'm not entirely sure if I'm missing something, so I left the source code unchanged.
Do you think this extra check is required?
Other Work
This PR also includes translation work, converting text from Chinese to English.
Checklist
Add or update API