Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve]Add frontend license. #1776

Merged
merged 3 commits into from
Apr 18, 2024
Merged

[improve]Add frontend license. #1776

merged 3 commits into from
Apr 18, 2024

Conversation

zqr10159
Copy link
Member

@zqr10159 zqr10159 commented Apr 18, 2024 •
edited
Loading

What's changed?

[improve]Add frontend license.
#1762

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@zqr10159 zqr10159 requested a review from tomsun28 April 18, 2024 08:57
tomsun28
tomsun28 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍👍

@tomsun28 tomsun28 merged commit f9d4779 into master Apr 18, 2024
2 checks passed
@zqr10159 zqr10159 deleted the front-license branch September 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
docs good first pull request Good for newcomers license
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zqr10159 @tomsun28