-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System config theme #1636
System config theme #1636
Conversation
Signed-off-by: tomsun28 <[email protected]>
hi, the new commit fix save theme prop has fix prop bing error. After that, we need to trigger the actual switching of the page color theme after choosing to switch the theme. |
We can refer the |
Okay, I'll try it |
hi,主题信息持久化这个我想我们可以通过 localstorage 和 数据库来做,在之前的颜色主题切换中,主题颜色信息是被存储到了web localstorage的一个字段里面了,关于你切换主题后有马上刷新变回来,我感觉就是之前那个字段导致的,需要我们也去变更下那个。 |
Hi, I think we can persist theme information through localstorage and database. In the previous color theme switching, the theme color information was stored in a field of web localstorage. Regarding the change that will be refreshed immediately after you switch the theme. Coming back, I feel that it was caused by the previous field, and we need to change that one too. |
Okay, I'll try it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What's changed?
The drop-down box is implemented, but there is a problem with rendering
i need help
Checklist
Add or update API