refactor code and fix some npe #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
reviewed
Aug 23, 2023
...main/java/org/dromara/hertzbeat/collector/collect/http/promethus/PrometheusMatrixParser.java
Outdated
Show resolved
Hide resolved
tomsun28
reviewed
Aug 23, 2023
...main/java/org/dromara/hertzbeat/collector/collect/http/promethus/PrometheusVectorParser.java
Outdated
Show resolved
Hide resolved
Signed-off-by: tomsun28 <[email protected]>
tomsun28
added a commit
that referenced
this pull request
Jan 16, 2024
Signed-off-by: tomsun28 <[email protected]> Co-authored-by: Carpe-Wang <[email protected]> Co-authored-by: tomsun28 <[email protected]>
tomsun28
added a commit
that referenced
this pull request
Mar 9, 2024
Signed-off-by: tomsun28 <[email protected]> Co-authored-by: Carpe-Wang <[email protected]> Co-authored-by: tomsun28 <[email protected]>
tomsun28
added a commit
that referenced
this pull request
Mar 9, 2024
Signed-off-by: tomsun28 <[email protected]> Co-authored-by: Carpe-Wang <[email protected]> Co-authored-by: tomsun28 <[email protected]>
tomsun28
added a commit
that referenced
this pull request
Mar 10, 2024
Signed-off-by: tomsun28 <[email protected]> Co-authored-by: Carpe-Wang <[email protected]> Co-authored-by: tomsun28 <[email protected]>
tomsun28
added a commit
that referenced
this pull request
Mar 10, 2024
Signed-off-by: tomsun28 <[email protected]> Co-authored-by: Carpe-Wang <[email protected]> Co-authored-by: tomsun28 <[email protected]>
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: tomsun28 <[email protected]> Co-authored-by: Carpe-Wang <[email protected]> Co-authored-by: tomsun28 <[email protected]>
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: tomsun28 <[email protected]> Co-authored-by: Carpe-Wang <[email protected]> Co-authored-by: tomsun28 <[email protected]>
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: tomsun28 <[email protected]> Co-authored-by: Carpe-Wang <[email protected]> Co-authored-by: tomsun28 <[email protected]>
tomsun28
added a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: tomsun28 <[email protected]> Co-authored-by: Carpe-Wang <[email protected]> Co-authored-by: tomsun28 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
简化，以及修一些潜在的空指针
将
new BigDecimal((Double) o * 1000)修改为BigDecimal.valueOf((Double) o * 1000)减少频繁的运算中导致内存浪费利用
try-with-resources删除finally代码块Checklist