Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] <add new field description in hertzbeat tag detail> #1482

Closed
2 tasks
tomsun28 opened this issue Jan 12, 2024 · 4 comments · Fixed by #1489
Closed
2 tasks

[Task] <add new field description in hertzbeat tag detail> #1482

tomsun28 opened this issue Jan 12, 2024 · 4 comments · Fixed by #1489
Assignees
Milestone

Comments

@tomsun28
Copy link
Contributor

Description

add new field description in hertzbeat tag detail

description varchar(255)

DROP TABLE IF EXISTS  hzb_tag ;
CREATE TABLE  hzb_tag
(
    id           bigint           not null auto_increment,
    name         varchar(100)     not null,
    `value`      varchar(100),
    type         tinyint   not null default 0,
    color        varchar(100),
    description  varchar(255),
    creator      varchar(100),
    modifier     varchar(100),
    gmt_create   timestamp        default current_timestamp comment 'create time',
    gmt_update   datetime         default current_timestamp on update current_timestamp comment 'update time',
    primary key (id),
    unique key unique_tag (name, `value`)
) ENGINE = InnoDB DEFAULT CHARSET=utf8mb4;

Task List

  • add new field description in hertzbeat tag detail
  • can add , edit tag description in webui
@GEM0816g
Copy link
Contributor

i would like to try it

@tomsun28
Copy link
Contributor Author

@GEM0816g 👍👍welcome, has assigned to you.

@GEM0816g
Copy link
Contributor

I encountered a problem in the front-end(前端) ,I have added fields and displayed them, but it seems to be ineffective. I didn't seem to find the right place. May I ask where this was rendered (my front-end is very poor)
1705241174679
And here
1705241558550

But it can be displayed normally in this place again
1705241250814

and there is also a small bug here
1705242635250

This is my first time solving it, and I am trying to work hard to solve it

@tomsun28

@tomsun28
Copy link
Contributor Author

hi👍👍, we can consider dispaly the description field in tag management page only. It is an additional description of the tag. If the user wants to know this description, he can go to the tag management page to view it.

@tomsun28 tomsun28 linked a pull request Jan 15, 2024 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this from To do to Done in hertzbeat-v1.0 Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants