Simplify the monitor template

[tomorrowshipyltm]

Hello, community

Background

There is a lot of duplication in the monitoring templates. For example, in the app-centos.yml file, different metrics only differ in the script and parseType, while other parameters like host, port, and username are repeated. This leads to longer YAML files.

protocol: ssh
  ssh:
    host: ^_^host^_^
    port: ^_^port^_^
    username: ^_^username^_^
    password: ^_^password^_^
    privateKey: ^_^privateKey^_^
    timeout: ^_^timeout^_^
    reuseConnection: ^_^reuseConnection^_^
    script: free -m
    parseType: multiRow

Suggestion

Consider extracting the repetitive parameters into a commonParam section, for example

commonParam:
      host: ^_^host^_^
      port: ^_^port^_^
      username: ^_^username^_^
      password: ^_^password^_^
protocol: ssh
ssh:
  script : uname
  parseType: multiRow

[tomsun28]

hi, thanks for suggestion. Protocol ssh http ... are already the common protocol abstract from protocols, there is no need to abstract a new common protocol from common protocol.

[tomorrowshipyltm]

sorry, i'm confused, I mean commonParam rather than commonProtocol, so every metric can reference commonParam in one template.yml

[tomsun28]

hi, under this commonParam design structure, what if the following metrics of the same one monitoring template use different collect protocols? If need modify a lot of work just to reduce the length of the yml template, sacrificing its readability and scalability, I personally think it is inappropriate