From a3eeab8c569068f4f85346733b46adb722524e51 Mon Sep 17 00:00:00 2001 From: chenglei Date: Wed, 27 Jul 2022 20:48:54 +0800 Subject: [PATCH] HBASE-27247 TestPerTableCFReplication.testParseTableCFsFromConfig is broken because of ReplicationPeerConfigUtil.parseTableCFsFromConfig (#4658) Co-authored-by: comnetwork Signed-off-by: Duo Zhang --- .../client/replication/ReplicationPeerConfigUtil.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java index b2ddc4eaec15..2fc5fa3c1152 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java @@ -125,7 +125,13 @@ public static ReplicationProtos.TableCF[] convert(String tableCFsConfig) { } // 2 split to "table" and "cf1,cf2" // for each table: "table#cf1,cf2" or "table" - Iterator i = Splitter.on(':').split(tab).iterator(); + List pair = Splitter.on(':').splitToList(tab); + if (pair.size() > 2) { + LOG.info("incorrect format:" + tableCFsConfig); + continue; + } + assert pair.size() > 0; + Iterator i = pair.iterator(); String tabName = i.next().trim(); if (tabName.length() == 0) { LOG.info("incorrect format:" + tableCFsConfig);