From 5e5d18bf212cec50fc7aa97609baee7613fc25c2 Mon Sep 17 00:00:00 2001 From: litao Date: Fri, 17 Jun 2022 08:18:18 +0800 Subject: [PATCH] HBASE-27117 Update the method comments for RegionServerAccounting (#4532) --- .../apache/hadoop/hbase/regionserver/MemStoreFlusher.java | 4 ++-- .../hadoop/hbase/regionserver/RegionServerAccounting.java | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java index ca4793e1023e..cc66bdde594a 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java @@ -432,14 +432,14 @@ private boolean refreshStoreFilesAndReclaimMemory(Region region) { } /** - * Return true if global memory usage is above the high watermark + * Return the FlushType if global memory usage is above the high watermark */ private FlushType isAboveHighWaterMark() { return server.getRegionServerAccounting().isAboveHighWaterMark(); } /** - * Return true if we're above the low watermark + * Return the FlushType if we're above the low watermark */ private FlushType isAboveLowWaterMark() { return server.getRegionServerAccounting().isAboveLowWaterMark(); diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java index bd9cdbe23b2b..fb13cd82ae84 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java @@ -161,8 +161,8 @@ public void decGlobalMemStoreSize(long dataSizeDelta, long heapSizeDelta, long o } /** - * Return true if we are above the memstore high water mark - * @return the flushtype + * Return the FlushType if we are above the memstore high water mark + * @return the FlushType */ public FlushType isAboveHighWaterMark() { // for onheap memstore we check if the global memstore size and the @@ -193,7 +193,8 @@ public FlushType isAboveHighWaterMark() { } /** - * Return true if we're above the low watermark + * Return the FlushType if we're above the low watermark + * @return the FlushType */ public FlushType isAboveLowWaterMark() { // for onheap memstore we check if the global memstore size and the