[#6177] improve(CLI): Refactor ownership commands in Gravitino CLI #6188
Conversation
Refactor ownership commands in Gravitino CLI
|
Hi @justinmclean @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback. |
| this.url = getUrl(line); | ||
| this.owner = line.getOptionValue(GravitinoOptions.USER); | ||
| this.group = line.getOptionValue(GravitinoOptions.GROUP); | ||
| this.name = new FullName(line); |
There was a problem hiding this comment.
This property is set but never used?
There was a problem hiding this comment.
name argument use to retrieve metalake and name.
| } | ||
|
|
||
| /** Handles the "SET" command. */ | ||
| private void handleSetCommand() { |
There was a problem hiding this comment.
I don't feel a need of the these two methods.
The logic of these two methods are pretty simple, straightforward.
Extracting them to separate private methods only increases the code complexity.
There was a problem hiding this comment.
This is to follow Metalake's rewritten specification
https://github.com/apache/gravitino/blob/332cb79fd85a2cbb568f7488f6c764cec0e6d4c2/clients/cli/src/main/java/org/apache/gravitino/cli/MetalakeCommandHandler.java#L144C1-L145C36
What changes were proposed in this pull request?
Refactor ownership commands in Gravitino CLI.
Why are the changes needed?
Fix: #6177
Does this PR introduce any user-facing change?
No
How was this patch tested?
local test.