Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #4633] Optimize the message body of the Rust SDK's returned reply message #4751

Merged
merged 2 commits into from
Jan 26, 2024
Merged

[ISSUE #4633] Optimize the message body of the Rust SDK's returned reply message #4751

merged 2 commits into from
Jan 26, 2024

Conversation

kyooosukedn
Copy link
Contributor

@kyooosukedn kyooosukedn commented Jan 19, 2024 •
edited
Loading

Fixes #4633 .

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Optimized the message body of the Rusk SDK's returned reply message

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia Pil0tXia changed the title [ISSUE #4633]Optimize the message body of the Rust SDK's returned reply message [ISSUE #4633] Optimize the message body of the Rust SDK's returned reply message Jan 20, 2024
@Pil0tXia Pil0tXia requested a review from mxsm January 20, 2024 06:59
mxsm
mxsm reviewed Jan 20, 2024
View reviewed changes
eventmesh-sdks/eventmesh-sdk-rust/src/grpc/grpc_consumer.rs Outdated
SubscriptionReply::SUB_TYPE.to_string(),
ProtocolKey::SUB_REPLY_MESSAGE.to_string(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to make changes here.

@mxsm
Copy link
Member

mxsm commented Jan 20, 2024

@kyooosukedn
image

@xwm1992 xwm1992 merged commit 032ff80 into apache:master Jan 26, 2024
9 checks passed
@kyooosukedn kyooosukedn deleted the 4633 branch March 27, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxsm mxsm mxsm approved these changes

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize the message body of the Rust SDK's returned reply message
3 participants
@kyooosukedn @mxsm @xwm1992