Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1091]add workflow/catalog grpc protocols #1239

Closed
wants to merge 2 commits into from
Closed

[#1091]add workflow/catalog grpc protocols #1239

wants to merge 2 commits into from

Conversation

walterlife
Copy link
Contributor

Fixes #1091

Motivation

Applications can access the EventMesh Workflow/AysncAPI capabilities through the EventMesh SDK to fill the event governance capabilities

Modifications

add workflow/catalog protocol into eventmesh-common module

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1239 (d201f7e) into master (5101b39) will decrease coverage by 0.73%.
The diff coverage is 0.25%.

@@             Coverage Diff              @@
##             master    #1239      +/-   ##
============================================
- Coverage     11.19%   10.46%   -0.74%     
- Complexity      758      765       +7     
============================================
  Files           421      432      +11     
  Lines         24580    26537    +1957     
  Branches       2683     2924     +241     
============================================
+ Hits           2752     2777      +25     
- Misses        21565    23499    +1934     
+ Partials        263      261       -2     
Impacted Files Coverage Δ
...in/java/org/apache/eventmesh/common/Constants.java 85.71% <ø> (ø)
...sh/common/protocol/catalog/protos/CatalogGrpc.java 0.00% <0.00%> (ø)
.../protocol/catalog/protos/EventmeshCatalogGrpc.java 0.00% <0.00%> (ø)
...mesh/common/protocol/catalog/protos/Operation.java 0.00% <0.00%> (ø)
...rotocol/catalog/protos/QueryOperationsRequest.java 0.00% <0.00%> (ø)
...otocol/catalog/protos/QueryOperationsResponse.java 0.00% <0.00%> (ø)
...ommon/protocol/catalog/protos/RegistryRequest.java 0.00% <0.00%> (ø)
...mmon/protocol/catalog/protos/RegistryResponse.java 0.00% <0.00%> (ø)
...rotocol/workflow/protos/EventmeshWorkflowGrpc.java 0.00% <0.00%> (ø)
...ommon/protocol/workflow/protos/ExecuteRequest.java 0.00% <0.00%> (ø)
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992
Copy link
Contributor

xwm1992 commented Sep 9, 2022

@walterlife please help to split the pr into two prs and associate the respective issues, namely workflow grpc protocol 、catalog grpc protocol, thanks.

@walterlife walterlife closed this Sep 9, 2022
@walterlife walterlife deleted the workflow-protocol branch September 9, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Java SDK adds EventMesh Workflow Client
2 participants