Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log): barMinHeight not work with startvalue greater than 10 #20541

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(log): barMinHeight not work with startvalue greater than 10 #20541

wants to merge 2 commits into from

Conversation

sz-p
Copy link
Contributor

@sz-p sz-p commented Nov 26, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

#20537

Details

Before: What was the problem?

image

After: How does it behave after the fixing?

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot ECharts Bot
Copy link

echarts-bot bot commented Nov 26, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@sz-p
Copy link
Contributor Author

sz-p commented Nov 26, 2024

Direct cause:

Axis: type: log not start with 0 in default like type: value.

It is start with mathLog(Math.max(0, start)) / base in https://github.com/apache/echarts/blob/master/src/scale/Log.ts#L90

Root cause:

startValue is not equal the start value in Axis extent. getValueAxisStart

P.S.

which one has higher priority? barMinHeight or min in axis.

Is this right?
image

startAngle is not work with min in coordinateSystem: 'polar'

image

https://echarts.apache.org/examples/zh/editor.html?c=bar-polar-label-tangential&code=PYBwLglsB2AEC8sDeAoWtJgDYFMBcsA2musiaRjgB5gEDkAKgIbQDmO0kTWsACsFiYAnWACFhsADJMARjh78AzhEgxYACgC2EACY7cASjrlYAXxIBdADQkQA4QVQUhTHRACuigoQDMABitYOgAOPwBSOgsSUxt0FlZcAEEqCC8yCk0mKgIAVgCTRTBhMES2XAIATnyMiGgCAEY_aNjYFzdPZNTHEzAATxB8IIBjJjAcVmAhXroW9B1Rpm86JhmgmVW6IY2dSOaSMGABSBBHGJJFHCEIHDSnUj6B-hlhGZN5ou96wMbAgCYA2D-awmIaHIRuaCjHAAZV6hRwmnodkEQleFEEciw3Qo6EUAAtgAB3AhgITuHCzUh2ZSqOpBbR6XBonEAM0mmTAYyE9CQMlMjiGpmMFHM6HMpgA3EA

@github-actions GitHub Actions
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20541@aad4735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: awaiting review PR: doc unchanged size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sz-p