From c4d3bf41f5bd0403190ea46ee8a58832930abab6 Mon Sep 17 00:00:00 2001 From: susiwen8 Date: Tue, 3 May 2022 12:27:34 +0800 Subject: [PATCH 1/2] feat(piecewise): `selecedtMode` support `boolean` --- src/component/visualMap/PiecewiseModel.ts | 2 +- src/component/visualMap/PiecewiseView.ts | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/component/visualMap/PiecewiseModel.ts b/src/component/visualMap/PiecewiseModel.ts index 3800d2b72d..a0fff4b7bb 100644 --- a/src/component/visualMap/PiecewiseModel.ts +++ b/src/component/visualMap/PiecewiseModel.ts @@ -104,7 +104,7 @@ export interface PiecewiseVisualMapOption extends VisualMapOption { * When categories: {'cate1': false, 'cate3': true} When selected === false, means all unselected. */ selected?: Dictionary - selectedMode?: 'multiple' | 'single' + selectedMode?: 'multiple' | 'single' | boolean /** * By default, when text is used, label will hide (the logic diff --git a/src/component/visualMap/PiecewiseView.ts b/src/component/visualMap/PiecewiseView.ts index f3f260593e..b110c63af9 100644 --- a/src/component/visualMap/PiecewiseView.ts +++ b/src/component/visualMap/PiecewiseView.ts @@ -215,10 +215,13 @@ class PiecewiseVisualMapView extends VisualMapView { ) { const visualMapModel = this.visualMapModel; const option = visualMapModel.option; + if (!option.selectedMode) { + return; + } const selected = zrUtil.clone(option.selected); const newKey = visualMapModel.getSelectedMapKey(piece); - if (option.selectedMode === 'single') { + if (option.selectedMode === 'single' || option.selectedMode === true) { selected[newKey] = true; zrUtil.each(selected, function (o, key) { selected[key] = key === newKey; From 5df98aec4edcc0549c32fa27e9cc341a51fd0921 Mon Sep 17 00:00:00 2001 From: susiwen8 Date: Tue, 3 May 2022 14:34:56 +0800 Subject: [PATCH 2/2] lint: code style --- src/component/visualMap/PiecewiseView.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/component/visualMap/PiecewiseView.ts b/src/component/visualMap/PiecewiseView.ts index b110c63af9..d94b0ed758 100644 --- a/src/component/visualMap/PiecewiseView.ts +++ b/src/component/visualMap/PiecewiseView.ts @@ -215,13 +215,14 @@ class PiecewiseVisualMapView extends VisualMapView { ) { const visualMapModel = this.visualMapModel; const option = visualMapModel.option; - if (!option.selectedMode) { + const selectedMode = option.selectedMode; + if (!selectedMode) { return; } const selected = zrUtil.clone(option.selected); const newKey = visualMapModel.getSelectedMapKey(piece); - if (option.selectedMode === 'single' || option.selectedMode === true) { + if (selectedMode === 'single' || selectedMode === true) { selected[newKey] = true; zrUtil.each(selected, function (o, key) { selected[key] = key === newKey;