Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] dark theme not correct for line chart with legend type 'scroll' #20395

Closed
jpike88 opened this issue Oct 7, 2024 · 0 comments · Fixed by #20396
Closed

[Bug] dark theme not correct for line chart with legend type 'scroll' #20395

jpike88 opened this issue Oct 7, 2024 · 0 comments · Fixed by #20396
Labels
bug en This issue is in English theme topic: legend

Comments

@jpike88
Copy link

jpike88 commented Oct 7, 2024

Version

latest

Link to Minimal Reproduction

https://echarts.apache.org/examples/en/editor.html?c=area-stack

Steps to Reproduce

Just squish the window so it's skinny horizontally to make the scroller activate. Enable dark mode. See that the text is not light. See screenshot

Screenshot 2024-10-08 at 12 29 23 AM

Current Behavior

theme does not include the legend scroller for line chart

Expected Behavior

dark theme should include the legend scroller for line chart

Environment

- OS: macOS Sequoia
- Browser: Safari
- Framework: demo page on echarts website

Any additional comments?

No response
@jpike88 jpike88 added the bug label Oct 7, 2024
@echarts-bot echarts-bot bot added en This issue is in English pending We are not sure about whether this is a bug/new feature. labels Oct 7, 2024
@plainheart plainheart added theme and removed pending We are not sure about whether this is a bug/new feature. labels Oct 8, 2024
@plainheart plainheart added this to the 5.5.2 milestone Oct 8, 2024
@plainheart plainheart mentioned this issue Oct 8, 2024
Merged
8 tasks
@plainheart plainheart linked a pull request Oct 8, 2024 that will close this issue
fix(theme): fix legend page text color in dark mode #20396
Merged
8 tasks
@plainheart plainheart removed this from the 5.5.2 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug en This issue is in English theme topic: legend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(theme): fix legend page text color in dark mode apache/echarts
2 participants
@jpike88 @plainheart