fix(marker): fix markArea position when axis is with alignWithLabel
#19516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially fix #18499 . The case when some ticks are skipped due to overlapping is not fully fixed.
echarts-bot
bot
added
PR: author is committer
PR: awaiting review
PR: doc unchanged
labels
|
Thanks for your contribution! The pull request is marked to be |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19516@3a056bd |
plainheart
changed the title
alignWithLabel
plainheart
changed the title
alignWithLabelalignWithLabel
plainheart
approved these changes
Jan 16, 2024
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix (#18499). The case when some ticks are skipped due to overlapping is not fully fixed.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix the markArea position when axis has
axisTick.alignWithLabel: true.Fixed issues
When some ticks are skipped due to overlapping (with dataZoom), there still remain to be a bug. This problem is not fixed in this PR because I can't think of an easy way to fix this. I added this test case. We should fix this later.
Details
Before: What was the problem?
Wrong markArea position. Demo
After: How does it behave after the fixing?
Correct markArea position.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information