-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(labelLine): fix emphasis.labelLine
is not working in pie chart
#19180
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failed test case in the CI and run visual tests of all cases to make sure it doesn't break any changes. Please also note that #18800 was also trying to fix the same problem. The first PR that finds the correct solution will be merged. Thanks!
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19180@ce9e51a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the lint problems and this demo also fails.
In this section of the code comment, it is mentioned that if label is false, labelLine will not be displayed. So, should we modify it to mean that lableLine will not be affected no matter what the label is |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
emphasis.labelLine
is not working in pie chart
Brief Information
This pull request is in the type of:
What does this PR do?
solved problem:emphasis.labelLine not work in pie chart #19160
Fixed issues
https://github.com/apache/echarts/issues/19160
#19160
Details
Before: What was the problem?
label lines are not hidden when emphasis
After: How does it behave after the fixing?
When I select the blue section,label lines are hidden when emphasis
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information