Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legend): inherit legend rich text color from legend's options #18260

Merged
merged 2 commits into from
Apr 3, 2023
Merged

fix(legend): inherit legend rich text color from legend's options #18260

merged 2 commits into from
Apr 3, 2023

Conversation

ChepteaCatalin
Copy link
Contributor

@ChepteaCatalin ChepteaCatalin commented Feb 12, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Inherit the legend's rich text color from the legend's options.

Fixed issues

Details

Before: What was the problem?

Rich text within the legend was inheriting color from the theme instead of the colors configured in the legend.

After: How does it behave after the fixing?

The rich text within a legend is inheriting now the colors from the legend's configuration (legend.textStyle.color when the legend item is active and legend.inactiveColor when inactive). However, user is still able to set color in rich options which will override legend.textStyle.color.

The problem was fixed by specifying inheritColor option in createTextStyle function.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 12, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please also a test case for this issue. Please check the wiki.

@ChepteaCatalin
Copy link
Contributor Author

@Ovilia I've added a test case. Can you please review it?

@Ovilia Ovilia requested a review from pissang February 21, 2023 14:18
@Ovilia
Copy link
Contributor

Ovilia commented Feb 21, 2023

@pissang Please help review this PR. I'm not quite sure.

@Ovilia Ovilia merged commit f5bb3b0 into apache:master Apr 3, 2023
@echarts-bot
Copy link

echarts-bot bot commented Apr 3, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants