Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): fix label doesn't show in line series when ssr is enabled #18032

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Dec 7, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. Fix label doesn't show and line path doesn't update correctly in the line series when ssr is enabled.
  2. Fix a typo: seriesDalay -> seriesDelay

Fixed issues

Comparison

Before After
image image
image image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 7, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@plainheart plainheart added this to the 5.5.0 milestone Dec 7, 2022
@plainheart plainheart linked an issue Dec 7, 2022 that may be closed by this pull request
@@ -644,7 +644,7 @@ class LineView extends ChartView {

const lineGroup = this._lineGroup;

const hasAnimation = seriesModel.get('animation');
const hasAnimation = !ecModel.ssr && seriesModel.isAnimationEnabled();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seriesModel.isAnimationEnabled should have considerd ecModel.ssr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understand, we tried to fix the issue by disabling the animation in SSR mode.

@pissang pissang merged commit d6ab9d4 into master Dec 20, 2022
@echarts-bot
Copy link

echarts-bot bot commented Dec 20, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@wcccode
Copy link

wcccode commented Nov 15, 2024

服务端nodeJs渲染图片,折线图数值未显示。

依赖:
canvas: "^2.11.2"
echarts: "^5.5.1"

测试数据:
var option = {
title: {
text: '每日增长趋势'
},
tooltip: {},
legend: {
data: ['活跃数'],
bottom: '10'
},
xAxis: {
data: ['2024-10-1', '2024-10-2', '2024-10-3', '2024-10-4', '2024-10-5', '2024-10-6', '2024-10-7', '2024-10-8', '2024-10-9', '2024-10-10', '2024-10-11', '2024-10-12', '2024-10-13', '2024-10-14', '2024-10-15']
},
yAxis: {},
series: [{
name: '活跃数',
type: 'line',
data: [86, 38, 45, 37, 37, 37, 60, 589, 545, 653, 891, 838, 225, 708, 597],
label: {
show: true, // 显示每个数据点的标签
position: 'top', // 标签的位置,可以是 'top', 'left', 'right', 'bottom'
formatter: '{c}' // 显示数据的值
}
}]
};

测试结果:
chart

@aquamarine5
Copy link

服务端nodeJs渲染图片,折线图数值未显示。

依赖: canvas: "^2.11.2" echarts: "^5.5.1"

测试数据: var option = { title: { text: '每日增长趋势' }, tooltip: {}, legend: { data: ['活跃数'], bottom: '10' }, xAxis: { data: ['2024-10-1', '2024-10-2', '2024-10-3', '2024-10-4', '2024-10-5', '2024-10-6', '2024-10-7', '2024-10-8', '2024-10-9', '2024-10-10', '2024-10-11', '2024-10-12', '2024-10-13', '2024-10-14', '2024-10-15'] }, yAxis: {}, series: [{ name: '活跃数', type: 'line', data: [86, 38, 45, 37, 37, 37, 60, 589, 545, 653, 891, 838, 225, 708, 597], label: { show: true, // 显示每个数据点的标签 position: 'top', // 标签的位置,可以是 'top', 'left', 'right', 'bottom' formatter: '{c}' // 显示数据的值 } }] };

测试结果: chart

一样 字体在SVG中渲染了 但是fill-opacity被设置为0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] new SVG renderer fails to render labels on line charts
5 participants